Magnus Damm wrote:
On Wed, Jul 2, 2008 at 4:43 PM, Paulius Zaleckas <paulius.zaleckas@xxxxxxxxxxxx> wrote:Heh. I have written almost identical videobuf driver also :) You should run checkpatch.pl on this patch to correct some style problems. Since your version is a little bit more generic than mine: Acked-by: Paulius Zaleckas <paulius.zaleckas@xxxxxxxxxxxx>Thanks for your ack. Just curious, which checkpatch version are you using? From the linux-next tree? I've checked my patches with the less agressive checkpatch included in the linux-2.6 tree. =)
Strange why checkpatch.pl didn't catch this:
+static void *__videobuf_alloc(size_t size)
+{
+ struct videobuf_dma_contig_memory *mem;
+ struct videobuf_buffer *vb;
+
+ vb = kzalloc(size + sizeof(*mem), GFP_KERNEL);
+ if (vb) {
+ mem = vb->priv = ((char *)vb)+size;
Should be mem = vb->priv = ((char *)vb) + size;
+ mem->magic = MAGIC_DC_MEM;
+ }
+
+ return vb;
+}
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list