***BOGO*** Re: [MPlayer-dev-eng] [PATCH] Fix packed YUV in dshow vo

[Sascha Sommer <saschasommer@xxxxxxxxxx>]

Hi,

On Montag, 6. Oktober 2008, Laurent wrote:
> On 10/6/08, Laurent <laurent.aml@xxxxxxxxx> wrote:
> > On 10/6/08, Reimar Döffinger <Reimar.Doeffinger@xxxxxxxxxxxxxxxxxxxxx> 
wrote:
> > > Hm, I didn't read the patch properly before, but now I realize: is that
> > > not the same thing that
> > > memcpy_pic(image, mpi->planes[0], FFMIN(source_stride, dest_stride),
> > > dest_stride, source_stride); does?
> > > Except that FFMIN(source_stride, dest_stride) should actually be width
> > > * bytes_per_pixel.
> >
> > That's it.
> > This is definitely how other VOs are handling Packed YUV copy (eg
> > vo_xv.c).
>
> Though memcpy_pic is working, it seems that that directx vo also uses
> mem2agpcpy_pic.
> Is mem2agpcpy_pic preffered over memcpy_pic for directx?
>

I don't know what is better. I would suggest to use mem2agpcpy_pic for now so 
that at least this part of vo_directx is consistent ;) We can still convert 
the mem2agpcpy_pic calls to memcpy_pic in a later patch.

Regards

Sascha
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng