Re: [MPlayer-dev-eng] [PATCH] correct illegal instruction on < armv5tE

[Siarhei Siamashka <siarhei.siamashka@xxxxxxxxx>]

On Wednesday 08 October 2008, GNUtoo@xxxxxxxxxx wrote:
> hello, I wanted to cross-compile mplayer from svn but it failed...that's
> because the pld instruction is not supported by my platform(armv4):
> More precisely the pld instruction was introduced in armv5tE variants( but
> is not present on armv5texp)
>
> here's the compilation faillure:

[...]

> With the patch it builds and runs fine(I tested youtube videos with a
> script)

A better fix is to update configure script to support detection of 
availability of PLD instruction in the same way as it is done in FFmpeg.

> I bet the patch won't be accepted as-is because it has a performance cost
> on the platform where the pld instruction is supported because the pld
> instruction preloads things...

The usefulness of PLD instruction there is quite questionable even on the 
platforms which support it. The code needs to be benchmarked.

-- 
Best regards,
Siarhei Siamashka
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng