***BOGO*** Re: [MPlayer-dev-eng] [PATCH] Fix packed YUV in dshow vo

[Laurent <laurent.aml@xxxxxxxxx>]

On 10/6/08, Reimar Döffinger <Reimar.Doeffinger@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Hm, I didn't read the patch properly before, but now I realize: is that
> not the same thing that
> memcpy_pic(image, mpi->planes[0], FFMIN(source_stride, dest_stride), dest_stride, source_stride);
> does?
> Except that FFMIN(source_stride, dest_stride) should actually be width *
> bytes_per_pixel.

That's it.
This is definitely how other VOs are handling Packed YUV copy (eg vo_xv.c).

I was not sure how to compute the bytes per line, since
bytes_per_pixel is an average, though, this seems not to be an issue.

Attached, the final patch, I guess.

Thanks,
Laurent

Index: libvo/vo_directx.c
===================================================================
--- libvo/vo_directx.c	(revision 27514)
+++ libvo/vo_directx.c	(working copy)
@@ -1276,7 +1276,7 @@
 	}
 	else //packed
 	{
-        fast_memcpy( image, mpi->planes[0], image_height * dstride);
+        memcpy_pic(image, mpi->planes[0], w * (mpi->bpp / 8), h, dstride, mpi->stride[0]);
 	}
 	return VO_TRUE;
 }

_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng