***BOGO*** Re: [MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

[Gregor Riepl <onitake@xxxxxxxxx>]

> I tested your patch on 10.4.11/PPC, and it doesn't compile:
>
> ....
>
> I do understand that your patch is not supposed to be finished yet,
> but I'd like to remind you that MPlayer should be kept backward
> compatible with 10.4 since Tiger packs everything that is needed for
> MPlayer to work well, and Tiger is also the last OS with which PPC
> machines have been shipped. I don't want to break support for that.

thanks for your feedback.
i assumed
#if MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_5
guards against exactly this. the existing code is still in, only when  
targeting 10.5+, the new IOPM api will be used.
the only problem with this is that simply changing the sdk doesn't  
suffice. you need to use the gcc parameter -mmacosx-version-min=10.4  
or 10.3 too.

the following works:
cc -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after- 
statement -std=gnu99 -Wall -Wno-switch -Wpointer-arith -Wredundant- 
decls -O4 -pipe -ffast-math -fomit-frame-pointer -mdynamic-no-pic - 
falign-loops=16 -shared-libgcc -D_LARGEFILE_SOURCE - 
D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -I.  -I/usr/local/include - 
I/usr/X11/include -I/usr/local/include/freetype2 -I/usr/local/include - 
c -o libvo/vo_macosx.o libvo/vo_macosx.m -isysroot /Developer/SDKs/ 
MacOSX10.4u.sdk -mmacosx-version-min=10.4 -arch ppc -faltivec

i'm not sure how to remedy this. is there a better way to check for  
the current sdk at compile time? or should the version-min parameter  
be added via the configure script?

_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng