***BOGO*** Re: [MPlayer-dev-eng] [PATCH] Move declarations of vo_font, sub_font to correct header file

[Uoti Urpala <uoti.urpala@xxxxxxxxxxx>]

On Tue, 2008-06-24 at 03:28 +0000, Bryan Henderson wrote:
> >The global variables vo_font and sub_font are defined in libvo/sub.c,
> >but declared in libvo/font_load.h.  They aren't even used by the font
> >loader code.
> >
> >This patch moves the declarations to libvo/sub.h.
> 
> So is any one interested in committing this?  Makes the code easier to
> maintain and costs nothing.

Most globals should be removed instead (moved to appropriate context
data structures). I have a tree where I've already removed many of them.
Those two were were still left, but I just removed the global sub_font
now.

_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng