***BOGO*** Re: [MPlayer-dev-eng] vo_gl PBO patch ..

[Sven Gothel <sgothel@xxxxxxxxxxx>]

To do the unification, one more question ..

Why is that orig Upload function so complicated ?
I might miss something here completly, but IMHO:

+++
  glAdjustAlignment(stride);
  glPixelStorei(GL_UNPACK_ROW_LENGTH, stride / glFmt2bpp(format, type));
  for (; y + slice <= y_max; y += slice) {
    glTexSubImage2D(target, 0, x, y, w, slice, format, type, data);
    data += stride * slice;
  }
  if (y < y_max)
    glTexSubImage2D(target, 0, x, y, w, y_max - y, format, type, data);
+++

equals to just:

+++
  glAdjustAlignment(stride);
  glPixelStorei(GL_UNPACK_ROW_LENGTH, stride / glFmt2bpp(format, type));
  glTexSubImage2D(target, 0, x, y, w, h, format, type, data);
+++

Any clue ?

Thanks for enlightning me ..

Cheers, Sven
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng