***BOGO*** Re: [Mingw-users] [SPAM] Re: Re: imlib2

[Ramiro Polla <ramiro@xxxxxxxxxxxxx>]

Hello,

>> +#define LOADERS_STR "\\loaders"
> 
>> -  sprintf(s, SYS_LOADERS_PATH "/loaders");
>> +  sprintf(s, SYS_LOADERS_PATH LOADERS_STR);
> 
> ...to replace slashes in path names by backslashes; MS-Windows is 
> perfectly happy to resolve path names expressed with the *nix style 
> slash as an alternative to its default backslash, and always has been; 
> even MS-DOS before it could handle this.

LoadLibrary()
http://msdn.microsoft.com/en-us/library/ms886736.aspx

IIRC dlfcn-win32 does this by itself, so it should be fine to use 
forward slashes. But I only wrote dlfcn-win32 after this patch.

>> -  if (!(__imlib_FilePermissions(fl) & (S_IRUSR | S_IRGRP | S_IROTH)))
>> +  if (!(__imlib_FilePermissions(fl) & (S_IRUSR)))
> 
> Rather than patch this in place, (where the code would normally apply 
> for every supported platform), it is usually cleaner to add a guarded 
> define for each platform specific unsupported attribute, e.g. ...
> 
>   #ifdef _WIN32
>   # define S_IRGRP 0
>   # define S_IROTH 0
>   #endif

Oh, I am completely aware that this patch is an ugly mess =) I also just 
thought "who cares about targa?" and removed any reference from it to 
the Makefiles. If I had to clean this up myself, I would have done 
differently. But now I see that there is an Enlightment project for GSoC 
2008 about this, so someone will take care of it.

Ramiro Polla

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
MinGW-users mailing list
MinGW-users@xxxxxxxxxxxxxxxxxxxxx

You may change your MinGW Account Options or unsubscribe at:
https://lists.sourceforge.net/lists/listinfo/mingw-users