***BOGO*** Re: [Mingw-users] [SPAM] Re: Re: imlib2

[Keith Marshall <keithmarshall@xxxxxxxxxxxxxxxxxxxxx>]

On Friday 02 May 2008 00:50, Ramiro Polla wrote:
> Ramiro Polla wrote:
> CFLAGS=-DBUILDING_DLL ./configure --without-x --disable-mmx

Unless the configure script was built with a very old autoconf, 
(pre-2.50), this is better expressed as

  ./configure CFLAGS=-DBUILDING_DLL --without-x --disable-mmx

and, while it's harmless, you don't *need* this sort of nonsense...

> +#define LOADERS_STR "\\loaders"

> -  sprintf(s, SYS_LOADERS_PATH "/loaders");
> +  sprintf(s, SYS_LOADERS_PATH LOADERS_STR);

...to replace slashes in path names by backslashes; MS-Windows is 
perfectly happy to resolve path names expressed with the *nix style 
slash as an alternative to its default backslash, and always has been; 
even MS-DOS before it could handle this.

> -  if (!(__imlib_FilePermissions(fl) & (S_IRUSR | S_IRGRP | S_IROTH)))
> +  if (!(__imlib_FilePermissions(fl) & (S_IRUSR)))

Rather than patch this in place, (where the code would normally apply 
for every supported platform), it is usually cleaner to add a guarded 
define for each platform specific unsupported attribute, e.g. ...

  #ifdef _WIN32
  # define S_IRGRP 0
  # define S_IROTH 0
  #endif

Regards,
Keith.

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
MinGW-users mailing list
MinGW-users@xxxxxxxxxxxxxxxxxxxxx

You may change your MinGW Account Options or unsubscribe at:
https://lists.sourceforge.net/lists/listinfo/mingw-users