lists.zerezo.com



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: KHTML color scheme patch



Hi, I built khtml and konqueror (this last without need it :)), the patch break completly the configuration of the styleshet, all the settings doesn't work becouse the background color always is white and the foreground color is black. Also konqueror is crashing on exit.

I'm attaching the bugtrace (btrace.txt), I don't know how works khtml to paint the pages but certainly it can't show all the pages when the background (and foreground) isn't the default. Perhaps the patch should use KStatefulBrush and KColorScheme::* instead QPalette.

Percy



On Thu, Jun 26, 2008 at 8:23 PM, Conor W Sullivan <premiersullivan@xxxxxxxxx> wrote:
Sorry, I meant to send this from a different account

Hi, where is the best place to discuss khtml issues?  The following is a patch
to kdelibs/khtml/khtml_part.cpp which simply sets the part's color scheme as
being a generic black-on-white color scheme.  This is because khtml often
works with webpages that conflict severly with dark color schemes.  I can add a
system settings option to disable this is you like.

To see the need for the patch, switch to a dark color scheme and navigate with
konqueror to a site like this:
http://www.usenix.org/event/usenix04/tech/freenix/full_papers/faure/faure_html/node5.html
The page is difficult to read because the background is a dark gray.  We can't
change how sites are written, but we can change how khtml handles it.

My patch fixes sites like this by simply settings the QPalette of the site to a
generic color scheme.  After applying my patch, the site renders well.

 However, it seems not to work on oxygen-rendered widgets.   Somewhere in
khtml code, I think that the QPalette is being overridden.  Look at sites like
www.facebook.com or www.google.com and see how the text boxes, buttons, etc
are still light on dark even with my patch.  On some sites , this can be very
problematic.  Any suggestions on how to make this patch better is appreciated.






>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


Attachment: btrace.kcrash
Description: Binary data

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<