lists.zerezo.com
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [StGIT PATCH] diffcol.sh: Use /bin/bash explicitly
- Date: Fri, 5 Sep 2008 22:35:46 +0100
- From: "Catalin Marinas" <catalin.marinas@xxxxxxxxx>
- Subject: Re: [StGIT PATCH] diffcol.sh: Use /bin/bash explicitly
2008/9/3 Karl Hasselström <kha@xxxxxxxxxxx>:
> On 2008-09-04 00:47:17 +0900, Shinya Kuribayashi wrote:
>
>> diffcol.sh is based on Quilt, and Quilt is dependent on bash;
>> Actually all Quilt scripts use /bin/bash without exceptions. Then
>> it's good for diffcol.sh to use /bin/bash.
>
> Thanks for this, and the other patch you sent. I'll be picking them up
> this weekend, unless Catalin beats me to it.
BTW, I think at some point we could change to using Git's native
colouring. The diffcol.sh script is from the days when Git didn't have
this feature. We currently generate a diff string and pass it through
the pager but I'm not sure how to do this.
--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html