lists.zerezo.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] be paranoid about closed stdin/stdout/stderr

Date: Wed, 27 Aug 2008 14:36:13 +0200
From: Paolo Bonzini <bonzini@xxxxxxx>
Subject: Re: [PATCH] be paranoid about closed stdin/stdout/stderr

>> But it's harmless to have both.
> 
> Considering the fact that daemon authors might not get pointed at their
> mistakes as soon as possible, it is harmful to try and hide those facts.

Agree.  OTOH what about opening fd's 0/1/2 to /dev/null only in
git-shell.c, now that it's not a builtin anymore?

Maybe it does not fix Karl's use case, but it seems sensible to me.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Follow-Ups:
- Re: [PATCH] be paranoid about closed stdin/stdout/stderr
  - From: Junio C Hamano
- [PATCH v4] make git-shell paranoid about closed stdin/stdout/stderr
  - From: Paolo Bonzini

References:
- [PATCH] Fix start_command() pipe bug when stdin is closed.
  - From: Karl Chen
- Re: [PATCH] Fix start_command() pipe bug when stdin is closed.
  - From: Johannes Sixt
- Re: [PATCH] Fix start_command() pipe bug when stdin is closed.
  - From: Paolo Bonzini
- [PATCH v2] fix start_command() bug when stdin is closed
  - From: Paolo Bonzini
- Re: [PATCH v2] fix start_command() bug when stdin is closed
  - From: Johannes Sixt
- Re: [PATCH v2 properly indented] fix start_command() bug when stdin is closed
  - From: Junio C Hamano
- [PATCH] be paranoid about closed stdin/stdout/stderr
  - From: Paolo Bonzini
- Re: [PATCH] be paranoid about closed stdin/stdout/stderr
  - From: Johannes Sixt
- Re: [PATCH] be paranoid about closed stdin/stdout/stderr
  - From: Stephen R. van den Berg
- Re: [PATCH] be paranoid about closed stdin/stdout/stderr
  - From: Avery Pennarun
- Re: [PATCH] be paranoid about closed stdin/stdout/stderr
  - From: Stephen R. van den Berg

Prev by Date: Re: [PATCH v2] allow user aliases for the --author parameter
Next by Date: Re: [PATCH v2] allow user aliases for the --author parameter
Previous by thread: Re: [PATCH] be paranoid about closed stdin/stdout/stderr
Next by thread: [PATCH v4] make git-shell paranoid about closed stdin/stdout/stderr
Index(es):
- Date
- Thread