lists.zerezo.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] help.c: Add support for htmldir relative to git_exec_path()

Date: Fri, 4 Jul 2008 13:35:24 +0100 (BST)
From: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
Subject: Re: [PATCH 1/2] help.c: Add support for htmldir relative to git_exec_path()

Hi,

On Fri, 4 Jul 2008, Junio C Hamano wrote:

> Could you check if there are copy-and-pasted duplicated code you can 
> factor out before continuing this direction?

Note also that Hannes tried very hard to get rid of those ugly "#ifdef 
__MINGW32__"s by declaring/overriding functions in git-compat-util.h.

I think that is such a good practice that we should not stop here.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Follow-Ups:
- Re: [PATCH 1/2] help.c: Add support for htmldir relative to git_exec_path()
  - From: Steffen Prohaska

References:
- Re: [PATCH 05/12] Windows(msysgit): Per default, display help as HTML in default browser
  - From: Steffen Prohaska
- [PATCH 1/2] help.c: Add support for htmldir relative to git_exec_path()
  - From: Steffen Prohaska
- Re: [PATCH 1/2] help.c: Add support for htmldir relative to git_exec_path()
  - From: Junio C Hamano

Prev by Date: Re: [PATCH/RFC] Fix some warnings (on cygwin) to allow -Werror
Next by Date: Re: [PATCH/v2] git-basis, a script to manage bases for git-bundle
Previous by thread: Re: [PATCH 1/2] help.c: Add support for htmldir relative to git_exec_path()
Next by thread: Re: [PATCH 1/2] help.c: Add support for htmldir relative to git_exec_path()
Index(es):
- Date
- Thread